Fix for #738#841
Conversation
GET requests like for Swagger do not have content-type set, causing #(encoder %) to eventually call a nil function. Encoder is now a noop if formatter is nil.
|
@harismh Thank you! I would be curious what you are using/experimenting with, couldn't find you on the Clojurians slack though. |
|
@whilo Thanks for the review and merge. Just added my GitHub handle to Clojurians, so that should make it easier to find me (lots of Haris's now haha.). I mainly work in internal enterprise systems, lately data brokerage and decision systems that have to interact with many different schemas. So, Datalog has always been on my radar. Enterprises tend to be pretty weary of new tech, so I did ultimately go with more traditional approaches. Believe Datahike's SQL adapter wasn't available back then either. But, my projects are winding down so I have spare time to help contribute back. I'll take a look at the other issues too. |
2 participants
SUMMARY
Fixes #738. Root cause was not swagger code itself, but local GET requests to swagger not having Content-Type set.
encode-plain-valuethen calls a nil function, causing the crash. Fix was to make the encoder a noop if nil. Added basic tests to better catch swagger issues in the future.Note: Had to run
codegen-javabefore runningbb http-server-uberon a first clone. I addedjcompileas build dependency tohttp-server-jcompileto workaround that.Checks
Bugfix
fixes #numberFeature
fixes #numberADDITIONAL INFORMATION
New tests pass. Original reproduction is fixed too.